Updated package.json and .babelrc ignored

ravinderk · 2019-03-11 13:20:52 UTC

Hi,

I found that travis ignored the updated package.json changed included .babelrc. I tried to flush cache and change package.json version but nothing worked.

To quick fix, I added logic to delete package.json and .babelrc after that download updated files from Github repo: https://github.com/impress-org/give/blob/release/2.4.2/tests/e2e/bin/install.sh#L18

Let me know if this an issue with travis or I am missing any configuration.

BanzaiMan · 2019-03-11 13:21:41 UTC

Please point to a relevant build log URL and explain:

What you expected to happen
What actually happened

Thanks.

ravinderk · 2019-03-11 16:25:26 UTC

@BanzaiMan

https://travis-ci.org/ravinderk/Give/builds/503066689

I expected package.json with verison 2.4.2 and updated .babelrc in build to run jest successfully. As you can see in commit both files was updated https://github.com/ravinderk/Give/commit/a5c2be0eeeb7fd30ebbf348dd834ff176ddc32c7

Let me know if you need any more details

BanzaiMan · 2019-03-11 16:43:59 UTC

In

github.com

ravinderk/Give/blob/a5c2be0eeeb7fd30ebbf348dd834ff176ddc32c7/tests/e2e/bin/install.sh#L12




echo "Give Log: current branch is ${TRAVIS_BRANCH}";
echo "${TRAVIS_PHP_VERSION:0:3}";
echo "${TRAVIS_EVENT_TYPE}"


if [[ ${TRAVIS_PHP_VERSION:0:3} != "5.3" ]] && [ "${TRAVIS_BRANCH}" == 'master' ]; then
	echo 'Give Log: setup and run frontend tests';


	until $(curl --output /dev/null --silent --head --fail http://localhost:8004); do printf '.'; sleep 5; done;
	cd ~/wordpress_data/wp-content/plugins
	git clone -b ${TRAVIS_BRANCH} --single-branch https://github.com/impress-org/give.git
	cd ~/wordpress_data/wp-content/plugins/give/
	docker exec give_wordpress_1 wp plugin activate give
	composer install
	rm -f package-lock.json
	rm -rf node_modules
	npm cache clean --force
	echo 'Latest package.json file:';
	cat package.json
	node --version
	npm --version

You are cloning https://github.com/impress-org/give.git into ~/wordpress_data/wp-content/plugins/give/ and looking at its package.json, not your repo’s.

I can’t tell you how you want to fix it, but this is expected behavior as you defined it.