Go can't find GCC with go1.11.1 on Windows

[keegancsmith]

See the PR here https://github.com/sourcegraph/go-langserver/pull/329 and example failing build https://travis-ci.org/sourcegraph/go-langserver/jobs/440629993

The key line here is

$ go test -timeout 5m -race ./...
#runtime/cgo
exec: "gcc": executable file not found in %PATH%

Do I need to adjust the PATH? Is there a known recipe for getting gcc onto the system (via choco I guess)? cgo is not uncommon, I’d suspect this would be a required dependency for building go.

Additionally I had issues with line endings. See the previous commits in the PR. The checkout is converting line endings to CRLF even though the gitattributes on the converted files have unset text. A resorted to using sed to fix the line endings.

[ameer1234567890]

Try running choco install -y mingw before go test

[josh]

Thanks for the tip @ameer1234567890

@keegancsmith if adding mingw does work, let me know and I will add it to the standard image.

Regarding :

Additionally I had issues with line endings. See the previous commits in the PR. The checkout is converting line endings to CRLF even though the gitattributes on the converted files have unset text. A resorted to using sed to fix the line endings.

Could you open another topic so we can track this?

[ameer1234567890]

@josh I think mingw should be added since gcc can be considered necessary even on Windows.